08-28-23 Planner Engineering Meeting

08-28-23 Planner Engineering Meeting

 Date

Aug 28, 2023

 Participants

  • @Kevin Ge

  • @Aravindan (Unlicensed)

  • @Enkang Yuan (Unlicensed)

  • @Brady Cash (Unlicensed)

  • @John Garza (Unlicensed)

  • @Peyton Barre

Agenda

  • Summer updates

    • Switched to Neon

    • Validator is now merged into main repo

    • New project lead!!

  • Jira, Confluence, GitHub access

    • Fill out: Planner - Team.

    • Documentation and design docs are now on Confluence.

  • Dev workflow/PR reviews discussion

    • Neon branching deployment can cause race conditions.

    • Are people willing to review PR’s?

  • 2 weeks sprint planning for just engineering.

  • Dev environment setup (optional + async)

  • https://nebula-labs.atlassian.net/jira/software/projects/NP/boards/3/backlog

Notes

  • Summer updates:

    • Switch to Neon, validator merged into main repo, new project lead (Ragini)

  • Are people willing to review PR’s?

    • Kevin: Was thinking we should do random reviewer with a Github action.

    • Arav: We should just let the person opening the PR request review, otherwise.

    • If you’re uncomfortable with review let Kevin or someone else on the team know.

  • Kevin: For reviews, we should have some sort of standardization, esp if everyone is doing reviews.

    • Arav: Doesn’t prettier enforce styling for us?

    • Style guide is suppose to be for code practices outside of just formatting.

  • Brady: Who merges PR?

    • Arav: Whoever is making the PR has to merge it.

    • Brady: Whoever was part of review merged it.

  • Cool with making design docs for larger issues / new features.

  • Cool w/ style guide (Kevin will contact Jason and send to team).

  • Comments/concerns with what happened last year:

    • Did docker ever happen? Nope.

    • GitPod, still talking with Jason about it

  • Sprint planning + Sentry access.

 Action items

Talk to Jason about style guide
GitHub access for Brady and Saidarsh.
Get Jira access for Enkang
Remove myself as mandatory default reviewer
Give sentry access to Ragini

 Decisions